Skip to content

Switch to master channel #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MattsAttack merged 1 commit into from
Jan 9, 2025
Merged

Switch to master channel #71

MattsAttack merged 1 commit into from
Jan 9, 2025

Conversation

@lishaduck
Copy link
Member

@lishaduck lishaduck commented Jan 8, 2025

Description

Describe your changes in a sentence or two.

This PR unblocks #39 (We're currently awaiting a CP (flutter/engine#57246) of flutter/engine#56949 to stable).
Once CP'd, we'd like to switch to the beta channel, instead of going back to stable.

Type of Change

  • 🛠️ Build configuration change

Checklist

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Fill out this template.
  • Log your hours.
  • Check that commits follow the Angular commit convention, more or less.
  • Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

  • CI
  • macOS 14

@lishaduck lishaduck added chore Relates to something miscellaneous dependencies Relates to dependencies labels Jan 8, 2025
@lishaduck lishaduck self-assigned this Jan 8, 2025
@lishaduck lishaduck requested a review from a team as a code owner January 8, 2025 02:55
@lishaduck lishaduck force-pushed the channel-master branch 2 times, most recently from ce76437 to 575ac6c Compare January 8, 2025 03:03
@MattsAttack
Copy link
Contributor

MattsAttack commented Jan 8, 2025

@lishaduck Trying to test this. It's returning this when I run melos bootstrap

PS C:\Users\matts\Desktop\Code Shit\Flutter_Projects\Town-Talk-Test\nexus> melos bootstrap
Resolving dependencies...
The current Flutter SDK version is 3.27.1.

Because nexus requires Flutter SDK version >=3.28.0-2.0.pre.38634, version solving failed.

Isn't 3.27.1 the newest version?

@lishaduck
Copy link
Member Author

lishaduck commented Jan 8, 2025

PS C:\Users\matts\Desktop\Code Shit\Flutter_Projects\Town-Talk-Test\nexus> melos bootstrap Resolving dependencies... The current Flutter SDK version is 3.27.1.

Because nexus requires Flutter SDK version >=3.28.0-2.0.pre.38634, version solving failed.

Isn't 3.27.1 the newest version?

Run flutter channel master

Can you show a screenshot of the failing ci logs? Securly's acting finicky, and actions logs are timeing out (among other things).

@MattsAttack
Copy link
Contributor

MattsAttack commented Jan 8, 2025 •
edited
Loading

edit:
I'm blind. didnt see the flutter channel master part. Trying that now

it works

MattsAttack
MattsAttack previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@MattsAttack MattsAttack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web build works

@lishaduck lishaduck force-pushed the channel-master branch 2 times, most recently from a5af481 to ad1c7ab Compare January 9, 2025 02:39
@codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.57%. Comparing base (e8a490d) to head (a5b6a16).
Report is 2 commits behind head on main.

@lishaduck lishaduck requested a review from MattsAttack January 9, 2025 13:40
MattsAttack
MattsAttack approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@MattsAttack MattsAttack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web and mac builds work!

@MattsAttack MattsAttack added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit f6ee95a Jan 9, 2025
11 checks passed
@MattsAttack MattsAttack deleted the channel-master branch January 9, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattsAttack MattsAttack MattsAttack approved these changes

Assignees

@lishaduck lishaduck

Labels

chore Relates to something miscellaneous dependencies Relates to dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lishaduck @MattsAttack